Skip to content

fix(esp_sr): Error with debug level log#11859

Merged
me-no-dev merged 1 commit intomasterfrom
fix/esp_sr_debug_message_uses_pointer
Sep 18, 2025
Merged

fix(esp_sr): Error with debug level log#11859
me-no-dev merged 1 commit intomasterfrom
fix/esp_sr_debug_message_uses_pointer

Conversation

@SuGlider
Copy link
Copy Markdown
Collaborator

@SuGlider SuGlider commented Sep 18, 2025

Description of Change

When compiling the ESP-SR Basic.ino example with DEBUG LEVEL = VERBOSE, there is a compilation error:

Compiling library "ESP_SR"
"C:\\Users\\esp\\AppData\\Local\\arduino\\sketches\\7228D85B768DE4388708EFAE81249F57\\libraries\\ESP_SR\\esp32-hal-sr.c.o"
In file included from C:\Users\esp\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.3.1\libraries\ESP_SR\src\esp32-hal-sr.c:39:
C:\Users\esp\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.3.1\libraries\ESP_SR\src\esp32-hal-sr.c: In function 'sr_start':
C:\Users\esp\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.3.1\libraries\ESP_SR\src\esp32-hal-sr.c:346:40: error: 'afe_config' is a pointer; did you mean to use '->'?
  346 |   log_d("load wakenet '%s'", afe_config.wakenet_model_name);
      |                                        ^
C:\Users\esp\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.3.1\cores\esp32/esp32-hal-log.h:139:76: note: in definition of macro 'log_d'
  139 | #define log_d(format, ...)     log_printf(ARDUHAL_LOG_FORMAT(D, format), ##__VA_ARGS__)
      |                                                                            ^~~~~~~~~~~
Using library ESP_I2S at version 3.3.0 in folder: C:\Users\esp\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.3.1\libraries\ESP_I2S 
Using library ESP_SR at version 3.3.0 in folder: C:\Users\esp\AppData\Local\Arduino15\packages\esp32\hardware\esp32\3.3.1\libraries\ESP_SR

Test Scenarios

Using ESP32-S3 with the https://github.com/espressif/arduino-esp32/blob/master/libraries/ESP_SR/examples/Basic/Basic.ino
Set Core Debug Level to Verbose.

Related links

Fixes #11857

@SuGlider SuGlider added this to the 3.3.0 milestone Sep 18, 2025
@SuGlider SuGlider self-assigned this Sep 18, 2025
@SuGlider SuGlider requested a review from me-no-dev as a code owner September 18, 2025 14:55
@SuGlider SuGlider added Type: Bug 🐛 All bugs Status: Review needed Issue or PR is awaiting review labels Sep 18, 2025
@SuGlider SuGlider moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Sep 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 36c9de8

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3
ExampleFLASHRAMFLASHRAM
libraries/ESP_SR/examples/Basic0000

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Sep 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2025 •
edited
Loading

Test Results

 76 files   76 suites   13m 11s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 36c9de8.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev merged commit c42facb into master Sep 18, 2025
71 of 73 checks passed
@me-no-dev me-no-dev deleted the fix/esp_sr_debug_message_uses_pointer branch September 18, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees

@SuGlider SuGlider

Labels

Status: Pending Merge Pull Request is ready to be merged Type: Bug 🐛 All bugs

Projects

Arduino ESP32 Core Project Roadmap
Status: Done

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

Compile error on 3.3.1

2 participants

@SuGlider @me-no-dev